@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Hey @hayata-suenaga @allroundexperts, the PR is open but I need to confirm the following scenarios before adding test proofs -

1. The text used -
   a. I added Delete stop for three dots menu item text.
   b. Delete stop (same as above) for the title of confirmation modal.
   c. Are you sure you want to delete this stop? for confirmation message/prompt in the modal.

Are these okay or should any of these use waypoint rather than stop? If so, I will request the spanish translations for these on slack.

2. The behaviour of this feature for start and finish points -
   

   App/src/libs/actions/Transaction.js

   Lines 92 to 103 in 253db32

   	function removeWaypoint(transactionID, currentIndex) {
   	// Index comes from the route params and is a string
   	const index = Number(currentIndex);
   	const transaction = lodashGet(allTransactions, transactionID, {});
   	const existingWaypoints = lodashGet(transaction, 'comment.waypoints', {});
   	const totalWaypoints = _.size(existingWaypoints);
   	// Prevents removing the starting or ending waypoint but clear the stored address only if there are only two waypoints
   	if (totalWaypoints === 2 && (index === 0 || index === totalWaypoints - 1)) {
   	saveWaypoint(transactionID, index, null);
   	return;
   	}

   Should the button be visible for start and finish point? I don't think it is a good idea because if start or finish is empty, it won't do anything. If they are filled, it will only clear the point rather than delete (which might be confusing).

Regarding point 2, if we allow deleting start/finish points, at the moment -

1. removeWaypoint clears the point if there are only 2 points - start and delete.
2. BUT if there is another stop added then start/finish are actually deleted and the point adjacent becomes the new start/delete.

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified tests pass on all platforms & I tested again on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Bump on these questions @hayata-suenaga!

@Nikhil-Vats sorry for the late response 🙇

The text used -

Let's use waypoint instead of stop. Please request Spanish translations for these 🙇

The behaviour of this feature for start and finish points -

When there are only two waypoints (start and finish), let's hide the three dot button

When there are several waypoints, even start or finish waypoints can be deleted. My only concern is that we're doing some weird stuff with how we store waypoints (I think waypoints are stored in an object with each key being waypoint0 or waypoint1...

Hey @hayata-suenaga @allroundexperts, I have requested for spanish translations on slack -

I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.

Can we also add the Waiting for Copy label on original GH right now or do we need to do it later?

I have also pushed the latest code to hide the three dots menu when there are only 2 points (start and finish). Regarding the concern of how we are storing, I will check on that right now and continue to test it and upload test proofs in a few hours.

@allroundexperts I have noticed one bug on main while testing which is that the confirm modal doesn't open when we first click delete workspace, it opens second time but then third time it doesn't open. This doesn't happen on staging so it is from a recent PR and it is also affecting our delete waypoint testing on mobile browsers.

This test video is from main without our changes so we know it is not from this PR. I will create a separate issue for this on slack.

@Nikhil-Vats Can you please report this (if it hasn't been reported previously) and post a link for the report here? As long as its present on main, it shouldn't block this PR.

Can we also add the Waiting for Copy label on original GH right now or do we need to do it later?

thank you for your attention to the guideline. I really appreciate it. In this case, because the change is very simple, I don't think we need marketing approval for this. But we still need Spanish translation confirmation.

This doesn't happen on staging so it is from a recent PR and it is also affecting our delete waypoint testing on mobile browsers.

so currently, when you first click the dot menu on the Waypoint Editor page, the menu popup doesn't appear?

@hayata-suenaga the menu pop up will appear but when we click Delete waypoint it won't show the confirmation modal. When we do it second time then it will show. This is happening for other confirmation modals as well.

This is only happening on mobile browsers, not on desktop. I will check for mobile apps.

@hayata-suenaga one more question, should we wait for Spanish translation to add test proofs and merge PR?

Or can we add test proofs and merge this PR and I can create a follow up PR as soon as we get Spanish translation?

should we wait for Spanish translation to add test proofs and merge PR?

you can record the screen or take screenshots before Spanish translation is approved. We should probably wait for Spanish translation before merging though

but again, we can do all the testing before Spanish

Can you please report this (if it hasn't been reported previously) and post a link for the report here?

@Nikhil-Vats by the way, did you have time to report the bug? (if you can find the PR that caused the regression, that's 💯

I will report the bug right now and try to find the root cause today.

@allroundexperts @hayata-suenaga Bug report added here.

@Nikhil-Vats Before working on that, can you please add the screen recordings so I can test as well.

Sure @allroundexperts , on it.

Hey @hayata-suenaga @allroundexperts, all test proofs added and checklist completed.

I noticed on further testing that not just the confirmation modal, many menus, pages don't open on first click. For ex - Notice the behaviour of clicking 'Request money' in the video below, it never works first time and always works the second time. So this problem is not just with the confirmation modal. This happens on mobile apps and mobile browsers.

This video is from main which you can verify because there is no option to delete the waypoints even when there are more than 2 points.

@allroundexperts Now, I will work to find out which PR caused this because this will become a major deploy blocker since it affects everything mobile and a lot of menu/pages possibly.

Also, you will notice in iOS native test video that the delete confirmation modal doesn't open at all. I tried multiple times it is the same behaviour but this is also because of the aforementioned bug and not this PR because you can try on main with delete workspace and there also the confirmation modal will never open.

@allroundexperts @hayata-suenaga Found the PR. The issue is already identified as it is affecting multiple flows - #25998.

There was only 1 change, BaseModal was changed to functional component, when I revert it everything works as expected.

I noticed one more CSS issue on android browser where it is difficult to click the finish point when there are more than 2 points. @hayata-suenaga you can check the test proof for chrome mobile to see it. Should I create a separate bug report for it?

I noticed one more CSS issue on android browser where it is difficult to click the finish point when there are more than 2 points. @hayata-suenaga you can check the test proof for chrome mobile to see it. Should I create a separate bug report for it?

@hayata-suenaga I think I already reported the same issue here as well. Let's create a bug ticket for that as well!

Hey @hayata-suenaga, I have fixed the merge conflict. Since so many people are working on this file, can we merge it quickly otherwise I am afraid we will keep running into conflicts.

I have tested the feature locally and the other feature which it had conflicts with and both work fine. And, the conflicts were simple so we didn't touch the code of the other feature.

Also, lint is failing on this PR but it is passing locally. and the reason for failing lint in this PR is because there was a prop added in the other PR which was not added in propTypes so it is not related to this PR.

I have added a comment on the other PR.

Also, lint is failing on this PR but it is passing locally. and the reason for failing lint in this PR is because there was a prop added in the other PR which was not added in propTypes so it is not related to this PR.

So the lint is failing on main?

@hayata-suenaga looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

As per this comment, we're merging the PR without lint test succeeding.

@Nikhil-Vats are you suggesting that this PR caused the lint error?

Yes @hayata-suenaga , I have put a comment on that PR so that the authors can confirm.

I didn't see your coment @Nikhil-Vats can you link it?

now I'm afraid that the lint error will fail tests on main 😨

@hayata-suenaga I've commented here

I can create a quick fix PR for the lint failure if this is super urgent.

@allroundexperts yep let's open a PR

Sure thing. Creating now.

Draft PR #26124

Filling in the checklist.

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.59-0 🚀

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.60-0 🚀

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.60-0 🚀

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀